feat: use the regitry url of npm by default#656
Open
zanminkian wants to merge 7 commits intonodejs:mainfrom
Open
feat: use the regitry url of npm by default#656zanminkian wants to merge 7 commits intonodejs:mainfrom
zanminkian wants to merge 7 commits intonodejs:mainfrom
Conversation
aduh95
requested changes
Feb 13, 2025
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
npm might not be on the path, we can't assume it's going to work this way. Also, it would introduce quite a heavy perf penalty to any corepack command, even those which have nothing to do with npm or its registry.
Contributor
Author
|
I will look into it in these few days. |
zanminkian
force-pushed
the
feat/registry_follow_npm
branch
from
635b244 to
9538922
Compare
zanminkian
force-pushed
the
feat/registry_follow_npm
branch
5 times, most recently
from
9ac82c2 to
e3bbdea
Compare
zanminkian
force-pushed
the
feat/registry_follow_npm
branch
from
e3bbdea to
d29d556
Compare
zanminkian
changed the title
COREPACK_NPM_REGISTRY defaults to the regitry of npm
Contributor
Author
|
There are many thumb-ups in #540, which means many people like this feature. Can someone help this PR move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #540
Closes #535
Closes #759